Hey Guys, I've requested this:
https://issues.apache.org/jira/browse/INFRA-7309 I agree with both Jay and Martin. I'd like to replace our entire RB/commit process (including for committers) with the Github integration. Regarding the commit history, this is something we should figure out. I like the way our history looks now, personally, but if it's between that and Github integration, I'd rather use Github PRs and have an uglier git history. Maybe we can just insist on all PRs being squashed before merge? Cheers, Chris On 2/12/14 6:51 AM, "Martin Kleppmann" <[email protected]> wrote: >+1 for using Github pull requests. They are much less laborious than >having to both create a RB and upload a patch to JIRA. I would suggest >that we use it for all commits, not just contributions by non-committers. > >They even mirror comments on a pull request to JIRA if the pull request >has the JIRA issue number in the title: >http://mail-archives.apache.org/mod_mbox/incubator-general/201402.mbox/%3C >[email protected]%3E -- which is a better integration >than we have with RB! > >Example: https://issues.apache.org/jira/browse/INFRA-7289 > >One caveat: using pull requests means the git commit history will look >different. At the moment, each JIRA corresponds to one commit (more or >less). With pull requests, each PR has a small branch (with one or more >commits on it) and a merge commit into trunk/master. I personally prefer >the PR model, because it allows making smaller, self-contained commits >(e.g. one commit for a refactor that is functionally neutral, and a >second commit that adds a feature on top of the refactoring) which is >easier to review than one big squashed commit. > >A downside of allowing multiple commits per PR it that people may be >tempted to submit messy commit histories. In that case we can still ask >them to squash commits, or rewrite the commit history into something >clean. So that shouldn't stop us from using Github PRs. > >Martin > >On 12 Feb 2014, at 00:43, Jay Kreps <[email protected]> wrote: >> So would we do this ourselves instead of the JIRA/rb thing? Or is this >>just >> for non-committer contributors? Are they providing this for >>non-incubator >> projects? Basically github greatly simplifies the pull/test/push cycle >>for >> patch review so I'd love to switch to this entirely... >> >> -Jay >> >> >> On Mon, Feb 10, 2014 at 3:55 PM, Chris Riccomini >><[email protected]>wrote: >> >>> Hey Jakob, >>> >>> I'd love to at least try it. If it's as easy as normal GH pull >>>requests, >>> I'd propose that we move to that model. >>> >>> Cheers, >>> Chris >>> >>> On 2/10/14 3:47 PM, "Jakob Homan" <[email protected]> wrote: >>> >>>> The infra folks are working on integrating github pull requests in >>>>the ASF >>>> workflow: >>>> >>> >>>http://mail-archives.apache.org/mod_mbox/incubator-general/201402.mbox/% >>>3C >>>> 52F61A30.1060405%40cord.dk%3E >>>> >>>> Not sure if this is something we want to pursue, but interesting, >>>> nonetheless. >>> >>> >
