Github user criccomini commented on a diff in the pull request:
https://github.com/apache/incubator-samza/pull/1#discussion_r9875033
--- Diff:
samza-kv/src/main/scala/org/apache/samza/storage/kv/LevelDbKeyValueStore.scala
---
@@ -27,17 +27,32 @@ import java.io._
import java.util.Iterator
import java.lang.Iterable
import org.apache.samza.config.Config
-import grizzled.slf4j.Logging
+import org.apache.samza.container.SamzaContainerContext
+import grizzled.slf4j.{Logger, Logging}
object LevelDbKeyValueStore {
- def options(config: Config) = {
+ private lazy val logger = Logger(classOf[LevelDbKeyValueStore])
+
+ def options(config: Config, containerContext: SamzaContainerContext) = {
--- End diff --
containerContext contains config, so we don't need both
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top-post your response.
If your project does not have this feature enabled and wishes so, or if the
feature is enabled but not working, please contact infrastructure at
[email protected] or file a JIRA ticket with INFRA.
---
