----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18357/ -----------------------------------------------------------
Review request for samza. Repository: samza Description ------- SAMZA-47 Clean up configuration for key-value store * stores.my-store.cache.size is now split into two different properties, stores.my-store.container.cache.size.bytes (LevelDB block cache size in bytes, per container) and stores.my-store.object.cache.size (Samza store cache size in number of objects, per task). * stores.my-store.write.buffer.size is now known as stores.my-store.container.write.buffer.size.bytes (semantics changed: was measured per-task, now measured per-container) * stores.my-store.compress is now known as stores.my-store.leveldb.compression (semantics changed: was a boolean, is now a string indicating the compression codec) * stores.my-store.batch.size is now known as stores.my-store.write.batch.size (unchanged semantics) * stores.my-store.leveldb.block.size is now known as stores.my-store.leveldb.block.size.bytes (unchanged semantics) Also changed default values for the properties that are now per-container. Behaviour of the following configuration properties did not change (but docs were brought up-to-date with the code): * stores.my-store.factory * stores.my-store.changelog * stores.my-store.key.serde * stores.my-store.msg.serde * stores.my-store.object.cache.size Manually tested changes (using hello-samza). Not yet figured out how to add automated tests for this. Diffs ----- docs/learn/documentation/0.7.0/container/state-management.md cafb0f873be320bf711afdf80d2a3132979ba384 samza-api/src/main/java/org/apache/samza/container/SamzaContainerContext.java PRE-CREATION samza-api/src/main/java/org/apache/samza/storage/StorageEngineFactory.java fe83c8e31972058a6cdf32642c842377fbc807d7 samza-core/src/main/scala/org/apache/samza/container/SamzaContainer.scala 13421d27d999225c25e65dc2ed7af80ba5a0339c samza-kv/src/main/scala/org/apache/samza/storage/kv/KeyValueStorageEngineFactory.scala ea75fab9c315a005cd15efe79cbd4ec0d5f13f38 samza-kv/src/main/scala/org/apache/samza/storage/kv/LevelDbKeyValueStore.scala 4c14aa2a44d32f8106081bf461905bfde0a07d04 samza-kv/src/test/scala/org/apache/samza/storage/kv/TestKeyValueStores.scala e99d4598abc5eaba443f90253530aa1e67a685b1 Diff: https://reviews.apache.org/r/18357/diff/ Testing ------- Thanks, Martin Kleppmann
