> On Feb. 27, 2014, 8:08 p.m., Jakob Homan wrote:
> > samza-api/src/main/java/org/apache/samza/system/SystemStreamMetadata.java,
> > line 112
> > <https://reviews.apache.org/r/18539/diff/2/?file=505020#file505020line112>
> >
> > This is interesting. Would it be better to not let nulls escape here
> > and return 0,0,1 for oldest, newest and upcoming offsets, respectively?
> > Would play more nicely with Scala. An isEmpty method would be easy to add.
I don't think we can do 0,0,1 as an escape for "empty stream" because 0,0,1 is
actually what would be returned if there were one message in the stream. We
could do 0,0,0, and just use the getUpcomingOffset.equals("0") to determine
whether a stream is empty or not. I like the null approach because it makes no
assumption about the offset style of the underlying system (i.e. if they're
integers or not).
- Chris
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18539/#review35691
-----------------------------------------------------------
On Feb. 26, 2014, 10:22 p.m., Chris Riccomini wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18539/
> -----------------------------------------------------------
>
> (Updated Feb. 26, 2014, 10:22 p.m.)
>
>
> Review request for samza.
>
>
> Repository: samza
>
>
> Description
> -------
>
> finish comments
>
>
> renaming metadata method in container to have it reflect reality.
>
>
> fix changelog to use oldest offset when restoring changelog streams
>
>
> Diffs
> -----
>
> samza-api/src/main/java/org/apache/samza/system/SystemStreamMetadata.java
> 48aa22467b095af1815ad511846d8d9a051958c4
> samza-core/src/main/scala/org/apache/samza/container/SamzaContainer.scala
> ebe3ed0ae6b7a025432fb8f632cdbc4d83fb9236
> samza-core/src/main/scala/org/apache/samza/container/TaskInstance.scala
> b42031e62d0588c26243ddeb7dcee4af69ff9482
> samza-core/src/main/scala/org/apache/samza/storage/TaskStorageManager.scala
> f4c019490322f31b63060a5f3d586cad618d63e4
>
> samza-core/src/test/scala/org/apache/samza/container/TestSamzaContainer.scala
> 555c95c37501d16f5a460819e5329378d7909c9d
>
> samza-test/src/test/scala/org/apache/samza/test/integration/TestStatefulTask.scala
> 387cf44dc71dde96e9dcb1f3e3fcca030c109365
>
> Diff: https://reviews.apache.org/r/18539/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Chris Riccomini
>
>
