----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18711/ -----------------------------------------------------------
Review request for samza. Repository: samza Description ------- adding tests for offset manager. cleaning up a random white space blip in TestUtil. move offset manager to checkpoint package. add documentation to offset manager. fix bootstrapping chooser to only use upcoming message offset. fix all tests. add stub tests for offset manager. add docs to offset manager merge master (SAMZA-142) add comment and logging to getDefaultOffset add offset manager. tests still failing, but everything is compiling. add getNextOffset to IncomingMessageEnvelope, and use it to checkpoint next offsets instead of current offsets. Diffs ----- samza-api/src/main/java/org/apache/samza/checkpoint/Checkpoint.java dcf81bf268d23653baed927fd60d7d8ba4bff747 samza-api/src/main/java/org/apache/samza/system/IncomingMessageEnvelope.java 4b143124d28308751f6725278d5afe57584c0d33 samza-api/src/main/java/org/apache/samza/system/SystemStreamMetadata.java 32e142a5edbffe2fe68ea9a4c9172e0f0db54922 samza-api/src/test/java/org/apache/samza/system/TestSystemStreamPartitionIterator.java 3ecabab9230f64dab203e3e19659828cbaefeb0e samza-api/src/test/java/org/apache/samza/util/TestBlockingEnvelopeMap.java cb4d14854671ea602785581f7ed243dffde4ec26 samza-core/src/main/scala/org/apache/samza/checkpoint/OffsetManager.scala PRE-CREATION samza-core/src/main/scala/org/apache/samza/config/StreamConfig.scala 517e9ae3572b64eacad3e7c123366033ab436230 samza-core/src/main/scala/org/apache/samza/config/SystemConfig.scala ce63a8aa3831ee18132a58d7b746853f181407c3 samza-core/src/main/scala/org/apache/samza/container/SamzaContainer.scala 9c2324473c632a630f85d2f4c822d601997cdc1b samza-core/src/main/scala/org/apache/samza/container/TaskInstance.scala 17449eead6d0806e5f1c1f85cea85f30510cf0fc samza-core/src/main/scala/org/apache/samza/serializers/SerdeManager.scala 4f3ff6e4da65559b0c0f5a5fd6a8786323f9a618 samza-core/src/main/scala/org/apache/samza/system/chooser/BootstrappingChooser.scala f7d3c8bb5cca28e501abe4ff07111f262bfbea74 samza-core/src/test/scala/org/apache/samza/checkpoint/TestOffsetManager.scala PRE-CREATION samza-core/src/test/scala/org/apache/samza/container/TestTaskInstance.scala 5e9dd0727291070481b2221c2a125c4ba7d8a4e7 samza-core/src/test/scala/org/apache/samza/system/chooser/TestBatchingChooser.scala d7632b4f3a5e5c4addb2d587dc430bdce7b3a678 samza-core/src/test/scala/org/apache/samza/system/chooser/TestBootstrappingChooser.scala 993daa6bf6d8d70726350434ae8b06227502b4ff samza-core/src/test/scala/org/apache/samza/system/chooser/TestDefaultChooser.scala 884e4587da0e66144cf3bcbe226fff0949f0d57f samza-core/src/test/scala/org/apache/samza/system/chooser/TestRoundRobinChooser.scala 01802b9c8d569dfbdd8db87ccef7ab63ed31f60a samza-core/src/test/scala/org/apache/samza/system/chooser/TestTieredPriorityChooser.scala 4cde630b94d8dce910bc9e43c5da94fde8a537f1 samza-core/src/test/scala/org/apache/samza/util/TestUtil.scala 60c96159f742d52dd17370394ab1a779f23359ac samza-kafka/src/main/scala/org/apache/samza/system/kafka/KafkaSystemConsumer.scala eb48aa306a6706db1ad0f91ead6b1270a7be370b samza-test/src/main/java/org/apache/samza/system/mock/MockSystemConsumer.java a282dbb2976cb916d41649c3fbe070008c6621ee Diff: https://reviews.apache.org/r/18711/diff/ Testing ------- Thanks, Chris Riccomini
