----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18824/#review36291 -----------------------------------------------------------
Ship it! Ship It! - Jakob Homan On March 5, 2014, 3:49 p.m., Chris Riccomini wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18824/ > ----------------------------------------------------------- > > (Updated March 5, 2014, 3:49 p.m.) > > > Review request for samza. > > > Repository: samza > > > Description > ------- > > use better isNull method for kafka payload null check > > > fix npe issue when reading null values from changelog > > > update test stateful task to trigger the npe. > > > Diffs > ----- > > > samza-kafka/src/main/scala/org/apache/samza/system/kafka/KafkaSystemConsumer.scala > eb48aa306a6706db1ad0f91ead6b1270a7be370b > > samza-kv/src/main/scala/org/apache/samza/storage/kv/KeyValueStorageEngine.scala > fc223834ff70ebec779d2e2b667fe9215732507e > > samza-test/src/test/scala/org/apache/samza/test/integration/TestStatefulTask.scala > 493c9843e543df9f7bde485912ce71fc321f0904 > > Diff: https://reviews.apache.org/r/18824/diff/ > > > Testing > ------- > > > Thanks, > > Chris Riccomini > >
