----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19524/#review38222 -----------------------------------------------------------
samza-core/src/main/scala/org/apache/samza/job/local/ThreadJob.scala <https://reviews.apache.org/r/19524/#comment70252> The only side effect of making this change, that I can think of, is that if the processing inside the thread throws some useful runtime exception other than Exception, then it will not be logged and we wouldn't know how to fix the issue. I'm not sure what the convention in Samza is to deal with this sort of logging issue? - Neha Narkhede On March 21, 2014, 11:27 a.m., Martin Kleppmann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19524/ > ----------------------------------------------------------- > > (Updated March 21, 2014, 11:27 a.m.) > > > Review request for samza. > > > Repository: samza > > > Description > ------- > > SAMZA-178 Don't catch Throwable, so that OutOfMemoryError kills the process. > > > Diffs > ----- > > samza-core/src/main/scala/org/apache/samza/container/SamzaContainer.scala > c101b59f3e476dcc2e3b7870d53d0d36002f2434 > samza-core/src/main/scala/org/apache/samza/job/local/ThreadJob.scala > 62994b0a2a0b61c9ddeb8c2a7e0569c9bce1681b > > samza-core/src/main/scala/org/apache/samza/serializers/CheckpointSerde.scala > f93f1c86c75842716638d841210cff718c8dd53e > > samza-core/src/test/scala/org/apache/samza/util/TestExponentialSleepStrategy.scala > 6cea6a29257553e239a7f31a5abb9177b72c487d > samza-core/src/test/scala/org/apache/samza/util/TestUtil.scala > 1bfd63cc6d37c6b2a3784e692e13cd97c37a92de > samza-kafka/src/main/scala/org/apache/samza/system/kafka/BrokerProxy.scala > f240d6972263510e9b76a98aa1b83783c297ea44 > > samza-kafka/src/test/scala/org/apache/samza/system/kafka/TestBrokerProxy.scala > bd1f82444ca6dce582bb08b0ac35f6b41cf1f913 > > samza-kafka/src/test/scala/org/apache/samza/system/kafka/TestKafkaSystemAdmin.scala > e43970cee622bcb13e6c5ec63539945f05314841 > > samza-kafka/src/test/scala/org/apache/samza/system/kafka/TestKafkaSystemFactory.scala > d08b9fac58799d4a870471951cd3a867547922a8 > > samza-test/src/test/scala/org/apache/samza/test/integration/TestStatefulTask.scala > 8177cbf9dd022b8e2c0c48dc5457a917d928b8f5 > samza-yarn/src/main/scala/org/apache/samza/job/yarn/YarnAppMaster.scala > 493819297a7e11eca7e97740281488fb74f2f6d5 > samza-yarn/src/main/scala/org/apache/samza/webapp/WebAppServer.scala > d524996fa9a5e145bcd516c87a2d7973595a5754 > > Diff: https://reviews.apache.org/r/19524/diff/ > > > Testing > ------- > > > Thanks, > > Martin Kleppmann > >
