----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20697/ -----------------------------------------------------------
(Updated April 25, 2014, 9:27 p.m.) Review request for samza. Changes ------- 1. moved unit test to a seperate method. have to repeat some code that is already in testSystemConumersShouldRegisterStartAndStopChooser, which I think should be fine. 2. catch _. And use the pattern you provided. (I like this pattern more). Repository: samza Description ------- Fail early when a consumer is misconfigured. 1. wraped the consumer register with try and catch 2. added SystemConsumerException extends SamzaException 3. added test for checking throwing the correct exception Diffs (updated) ----- samza-core/src/main/scala/org/apache/samza/system/SystemConsumers.scala 7624aef samza-core/src/test/scala/org/apache/samza/system/TestSystemConsumers.scala e1b211d Diff: https://reviews.apache.org/r/20697/diff/ Testing ------- Thanks, Yan Fang
