> On March 25, 2014, 7:25 p.m., Jakob Homan wrote: > > samza-core/src/main/scala/org/apache/samza/task/TaskCoordinators.scala, > > line 36 > > <https://reviews.apache.org/r/19384/diff/3/?file=532924#file532924line36> > > > > what's our style on single-line methods? I prefer inlining, but not > > sure if there's consensus.
I don't know if we have a house style rule; in this particular case I found it more readable to have the method body on a separate line. (For methods that return a short expression, like "def foo = bar.baz", I like inlining too.) > On March 25, 2014, 7:25 p.m., Jakob Homan wrote: > > samza-api/src/main/java/org/apache/samza/task/TaskCoordinator.java, line 28 > > <https://reviews.apache.org/r/19384/diff/3/?file=532919#file532919line28> > > > > Any reason to keep this method since it's just an equivalent to the > > more explicit one? Chris requested that we keep it (in this comment: https://issues.apache.org/jira/browse/SAMZA-179?focusedCommentId=13942483&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13942483) on the grounds of backwards compatibility. I don't mind whether we keep it or get rid of it. - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19384/#review38505 ----------------------------------------------------------- On March 22, 2014, 8:18 p.m., Martin Kleppmann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19384/ > ----------------------------------------------------------- > > (Updated March 22, 2014, 8:18 p.m.) > > > Review request for samza. > > > Repository: samza > > > Description > ------- > > SAMZA-179 Add caching of system metadata lookups > > > SAMZA-179 Rename ReadableCoordinator to TaskCoordinators; improve shutdown > method signature > > > SAMZA-179 Allow a task to detect when it has caught up, and shut down > gracefully. > > > Diffs > ----- > > build.gradle fc596267e38c53cfc44f1cf52f8d6acedc848da8 > gradle/dependency-versions.gradle 612670dded2c2d290f1bc36ece1f3d53ffa4e971 > samza-api/src/main/java/org/apache/samza/task/TaskContext.java > 611507ed340d9a3fb7b8cd5e0e0ce37b5561da32 > samza-api/src/main/java/org/apache/samza/task/TaskCoordinator.java > 192b226c9e6105cf666d484ac33bb0f854de7688 > samza-core/src/main/scala/org/apache/samza/container/SamzaContainer.scala > c101b59f3e476dcc2e3b7870d53d0d36002f2434 > samza-core/src/main/scala/org/apache/samza/container/TaskInstance.scala > c4b135c0f46edaa7fc0e4c0bf909e1ffa9515242 > samza-core/src/main/scala/org/apache/samza/system/StreamMetadataCache.scala > PRE-CREATION > samza-core/src/main/scala/org/apache/samza/task/ReadableCoordinator.scala > aaf631ec7acd710ab8a5b288f696233223569b60 > samza-core/src/main/scala/org/apache/samza/task/TaskCoordinators.scala > PRE-CREATION > samza-core/src/main/scala/org/apache/samza/util/Util.scala > 5b429dfece38d877175fa0495db6450e01d82689 > > samza-core/src/test/scala/org/apache/samza/container/TestSamzaContainer.scala > a2d5820e9eeb7590d208cf7fb7025c589f451bca > samza-core/src/test/scala/org/apache/samza/container/TestTaskInstance.scala > 27b4ca5d7995536aa66f63b7329caddf41865bb4 > > samza-core/src/test/scala/org/apache/samza/system/TestStreamMetadataCache.scala > PRE-CREATION > > samza-core/src/test/scala/org/apache/samza/task/TestReadableCoordinator.scala > c45ed9bb1b3916cd4c4043e36272b4e3508bfb87 > samza-core/src/test/scala/org/apache/samza/task/TestTaskCoordinators.scala > PRE-CREATION > > samza-test/src/test/scala/org/apache/samza/test/performance/TestSamzaContainerPerformance.scala > 3dc263011b955cfccac83e71384b865f8fc2b722 > > Diff: https://reviews.apache.org/r/19384/diff/ > > > Testing > ------- > > > Thanks, > > Martin Kleppmann > >
