> On May 27, 2014, 5:29 p.m., Chris Riccomini wrote: > > build.gradle, line 139 > > <https://reviews.apache.org/r/21921/diff/1/?file=594689#file594689line139> > > > > We don't need to exclude Jetty anymore? Has yarn-common removed it from > > their dependencies? If so, why do we need to keep excluding jetty-util? > > Zhijie Shen wrote: > The issue that I found was when I rebased it to YARN-2.4, the compilation > was failed due to Server class is not found in mortbay jetty package. Not > sure why SAMZA chooses to exclude it before.
K, I dug into this a bit. I was excluding the jetty module because I was under the mis-guided assumption that the org.mortbay.jetty and org.eclipse.jetty jars had code under the same package space, and would collide if both were included on the classpath. Looks like this is not true, so it's safe to include both. We are using jetty 8 for the AM's webapp, and YARN is using jetty 6 for their web stuff. Including both should be safe. Can you also remove the exclude jetty-util line as well? - Chris ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21921/#review43990 ----------------------------------------------------------- On May 27, 2014, 6:13 a.m., Zhijie Shen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21921/ > ----------------------------------------------------------- > > (Updated May 27, 2014, 6:13 a.m.) > > > Review request for samza. > > > Repository: samza > > > Description > ------- > > SAMZA-186: Upgrade Samza to YARN 2.4 > > > Diffs > ----- > > build.gradle 45697df > gradle/dependency-versions.gradle 819a578 > > samza-yarn/src/test/scala/org/apache/samza/job/yarn/TestSamzaAppMasterLifecycle.scala > cce63eb > > samza-yarn/src/test/scala/org/apache/samza/job/yarn/TestSamzaAppMasterTaskManager.scala > 7fd80d5 > > Diff: https://reviews.apache.org/r/21921/diff/ > > > Testing > ------- > > > Thanks, > > Zhijie Shen > >
