----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22276/ -----------------------------------------------------------
(Updated June 7, 2014, 12:38 a.m.) Review request for samza. Changes ------- Thanks for reviewing! 1, created a case class StreamFetchSizes in DefaultFetchSimpleConsumer, which has two values: default/system-level fetchSize (Int) and stream->value (Map) 2, use the case class instead of the tuple 3, fix the resetVale to fetchSizeValue. Thank you. Repository: samza Description ------- Add stream-level overrides for kafka fetch size config 1. added getFetchMessageMaxBytesTopics method which returns a map topic->fetchSize 2. used a tuple (default value, map) for all fetchSize variable. First element is the default or shared fetch size value, second element is the map from 1) 3. changed relevent class/methods (BrokerProxy, KafkaSystemConsumer, DefaultFetchSimpleConsumer) to accept the new type of fetch size 4. unit test Diffs (updated) ----- samza-kafka/src/main/scala/org/apache/samza/config/KafkaConfig.scala 4deabd3 samza-kafka/src/main/scala/org/apache/samza/system/kafka/BrokerProxy.scala e08791f samza-kafka/src/main/scala/org/apache/samza/system/kafka/DefaultFetchSimpleConsumer.scala d90ca78 samza-kafka/src/main/scala/org/apache/samza/system/kafka/KafkaSystemConsumer.scala f1edda0 samza-kafka/src/main/scala/org/apache/samza/system/kafka/KafkaSystemFactory.scala f4dc1c1 samza-kafka/src/test/scala/org/apache/samza/config/TestKafkaConfig.scala 93cf5a5 samza-kafka/src/test/scala/org/apache/samza/system/kafka/TestBrokerProxy.scala 9c0ca60 Diff: https://reviews.apache.org/r/22276/diff/ Testing ------- Thanks, Yan Fang
