----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22524/#review45532 -----------------------------------------------------------
Applied patch and ran. It seems some JARs are still included: criccomi-mn:samza-sources-0.7.0-incubating criccomi$ find . | grep jar$ ./samza-api/bin/build/libs/samza-api-0.7.0.jar ./samza-api/bin/build/tmp/jar ./samza-kafka/lib/kafka_2.10-0.8.1-SNAPSHOT-test.jar ./samza-kafka/lib/kafka_2.9.2-0.8.1-SNAPSHOT-test.jar I'm guessing that bin is a relic from some old build or eclipse or something, and I know we're blocked on getting the kafka test jars into Maven. Can you confirm that you don't see the bin samza-api jar on your end? build.gradle <https://reviews.apache.org/r/22524/#comment80378> Can we move this into a gradle/release.gradle file? Same with apply plugin: 'base' above. Also, add sourceRelease task docs to RELEASE.md docs. - Chris Riccomini On June 12, 2014, 7:45 p.m., Jakob Homan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22524/ > ----------------------------------------------------------- > > (Updated June 12, 2014, 7:45 p.m.) > > > Review request for samza. > > > Bugs: samza-283 > https://issues.apache.org/jira/browse/samza-283 > > > Repository: samza > > > Description > ------- > > source release task > > > Diffs > ----- > > build.gradle 7346bdb > gradle.properties da0de97 > gradle/wrapper/gradle-wrapper.properties 610282a > gradlew 16bbbbf > > Diff: https://reviews.apache.org/r/22524/diff/ > > > Testing > ------- > > manual > > > Thanks, > > Jakob Homan > >
