> On May 5, 2014, 4:58 p.m., Chris Riccomini wrote:
> > docs/learn/documentation/0.7.0/jobs/reprocessing.md, line 10
> > <https://reviews.apache.org/r/20989/diff/1/?file=573070#file573070line10>
> >
> >     "If the new version produces different output from the old version, 
> > anyone who is consuming your job's output will see the output stream switch 
> > from the old version to the new version at this point."
> >     
> >     This is a little confusing. I associate the word "output" with the 
> > payload of a message. The word "stream" I associate with an output stream. 
> > If a job produces different output, that to me sounds like it's adding a 
> > field, but sending to the same stream. I think you're actually saying if 
> > the job produces to a different stream in the newer version, right?

Yes, that's what I meant, but it's confusing. I'll just delete that sentence, 
as I think it's more confusing than helpful.


> On May 5, 2014, 4:58 p.m., Chris Riccomini wrote:
> > docs/learn/documentation/0.7.0/jobs/reprocessing.md, line 57
> > <https://reviews.apache.org/r/20989/diff/1/?file=573070#file573070line57>
> >
> >     Might be useful to provide a real-world example here, just to make 
> > things clear. This concept is a bit abstract without detailed explanation.

Good point, I've added one.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20989/#review42161
-----------------------------------------------------------


On June 13, 2014, 5:27 p.m., Martin Kleppmann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20989/
> -----------------------------------------------------------
> 
> (Updated June 13, 2014, 5:27 p.m.)
> 
> 
> Review request for samza.
> 
> 
> Repository: samza
> 
> 
> Description
> -------
> 
> SAMZA-252: Add page on reprocessing to the docs.
> 
> 
> Diffs
> -----
> 
>   docs/_config.yml 2b90b08bafc5746efeae486daebc458f5c41847d 
>   docs/learn/documentation/0.7.0/container/checkpointing.md 
> 5b5261d998aed01530321e285a03115791cfba6d 
>   docs/learn/documentation/0.7.0/index.html 
> 695abf235b0bbdb9f7d8e351f8c04d3b796c976a 
>   docs/learn/documentation/0.7.0/jobs/logging.md 
> 9b5fea87bde15a6f034380c2dd4324d1127a8e93 
>   docs/learn/documentation/0.7.0/jobs/reprocessing.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/20989/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Kleppmann
> 
>

Reply via email to