> On June 23, 2014, 7:34 p.m., David Chen wrote:
> > docs/css/main.css, line 223
> > <https://reviews.apache.org/r/22801/diff/1/?file=613693#file613693line223>
> >
> >     It looks like we added these to the CSS and not to the documentation. I 
> > have restored img.diagram-large. I think we can leave the table styles out; 
> > I have updated the HTML for the tables to use Bootstrap's table styles.

That was me who edited the CSS file directly -- thanks for fixing it. I didn't 
realise the CSS was compiled from LESS.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22801/#review46430
-----------------------------------------------------------


On June 23, 2014, 7:35 p.m., David Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22801/
> -----------------------------------------------------------
> 
> (Updated June 23, 2014, 7:35 p.m.)
> 
> 
> Review request for samza.
> 
> 
> Bugs: SAMZA-301
>     https://issues.apache.org/jira/browse/SAMZA-301
> 
> 
> Repository: samza
> 
> 
> Description
> -------
> 
> SAMZA-301: Add syntax highlighting to documentation code listings.
> 
> 
> Diffs
> -----
> 
>   docs/_config.yml 9ffb45c62196932081381660792033db58e5f5ff 
>   docs/_layouts/default.html 226e416c4615bbdd25b72165a21b58fa57070e85 
>   docs/contribute/code.md b9a3c0240fda508fbe1a9a02d656be47d3da44f0 
>   docs/css/main.css 9dd0b0c6cd77458581121bd765dbb7e1c555dd15 
>   docs/css/syntax.css PRE-CREATION 
>   docs/learn/documentation/0.7.0/api/overview.md 
> 7e06d4ea2649e54793de3066db4a6237711aa10b 
>   docs/learn/documentation/0.7.0/container/checkpointing.md 
> 434195a90ea13ff673aabeac92a7d58b7e9d7488 
>   docs/learn/documentation/0.7.0/container/event-loop.md 
> 7ea9fe968c859fc1751abeae8f931bf7b9695551 
>   docs/learn/documentation/0.7.0/container/jmx.md 
> 539ed58c672afffecda918b79e2cbf72a8cacf60 
>   docs/learn/documentation/0.7.0/container/metrics.md 
> c6acb520ad9b20f64690ce06adbd82995a091855 
>   docs/learn/documentation/0.7.0/container/samza-container.md 
> cdcf8b6d6205f56df286240169da4bb4d45df5b6 
>   docs/learn/documentation/0.7.0/container/serialization.md 
> 1bc09460be68bb48c1dfdb6784758a94d0472606 
>   docs/learn/documentation/0.7.0/container/state-management.md 
> d0215880f803de6d6227468f58ed1d7da75fa685 
>   docs/learn/documentation/0.7.0/container/streams.md 
> f17ba992d062c458d2512866a2e45ec36b717d62 
>   docs/learn/documentation/0.7.0/container/windowing.md 
> 312a4932e1ee13681472cf65257dc3c486a2131e 
>   docs/learn/documentation/0.7.0/introduction/architecture.md 
> 00a5e898ccf7982c26ec4bded1bb6c0ed8219ebb 
>   docs/learn/documentation/0.7.0/jobs/configuration.md 
> 7ed6402b3f681b5ffb1046a802a6ca642dcff1b3 
>   docs/learn/documentation/0.7.0/jobs/job-runner.md 
> 7fef2ec7146a419ef608e25b626d4bcbf153711a 
>   docs/learn/documentation/0.7.0/jobs/logging.md 
> b56bd67ae1cd66a31020d167536d0ca7e35c6d6a 
>   docs/learn/documentation/0.7.0/jobs/yarn-jobs.md 
> 12f5063880ff427e46a67e33119a457fa24d677b 
>   docs/learn/documentation/0.7.0/operations/kafka.md 
> b426fdb88e4a520951f1b827f95b80a207077485 
>   docs/learn/tutorials/0.7.0/deploy-samza-job-from-hdfs.md 
> 63bbf0717b63a616b6a475ae2a1b162217ad9f8a 
>   docs/learn/tutorials/0.7.0/remote-debugging-samza.md 
> c3623d8fe9ea113180a590ed4cbf20c171a5cea1 
>   docs/learn/tutorials/0.7.0/run-hello-samza-without-internet.md 
> 8ff5f1df01d7585c9f0fa7a31d1ca2ebf7c08888 
>   docs/learn/tutorials/0.7.0/run-in-multi-node-yarn.md 
> dc707902a0589af3651cb07bd03ddeb998af0356 
>   docs/less/main.less 8c7cea678dfe49eb6c9621171858967d156298ac 
>   docs/startup/download/index.md 1cb1227630826d9eba5ac0a38a98143110279297 
>   docs/startup/hello-samza/0.7.0/index.md 
> d8138497fad486e99e7b19d9779a0b9cb7a7523a 
> 
> Diff: https://reviews.apache.org/r/22801/diff/
> 
> 
> Testing
> -------
> 
> Manual.
> 
> 
> Thanks,
> 
> David Chen
> 
>

Reply via email to