----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23300/#review47393 -----------------------------------------------------------
Looking good. * rat doesn't seem to run as part of the check command, as the old license plugin did. We should have it do so. * Please add gradle doc comment to the rat command so it shows up in ./gradlew tasks description * buildscript.gradle has both a repo and a dependency for the old plugin that can now be removed. - Jakob Homan On July 6, 2014, 8:39 p.m., David Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23300/ > ----------------------------------------------------------- > > (Updated July 6, 2014, 8:39 p.m.) > > > Review request for samza. > > > Bugs: SAMZA-285 > https://issues.apache.org/jira/browse/SAMZA-285 > > > Repository: samza > > > Description > ------- > > SAMZA-285: Use Apache Rat for release audit tests. > > > Diffs > ----- > > build.gradle f1a458b8c4cbe6e38f28ba3c5bd9099590c7abde > gradle/license.gradle 82aca213d53cb81c17e705973c4f30d28212d312 > gradle/rat-output-to-html.xsl PRE-CREATION > gradle/rat.gradle PRE-CREATION > > Diff: https://reviews.apache.org/r/23300/diff/ > > > Testing > ------- > > Manual. > > > Thanks, > > David Chen > >
