-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23235/
-----------------------------------------------------------

(Updated July 13, 2014, 5:44 a.m.)


Review request for samza.


Changes
-------

1. added debug and metrics
2. isolated the serdeManager.fromBytes and serdeManager.toBytes
3. added the same feature to SystemProducers: a new property 
"task.drop.serialization.errors" to define whether dropping the messages or not 
when serialization error occurs.


Repository: samza


Description
-------

Support dropping messages on serde failures.

1. added a task property: task.drop.deserialization.errors . If set to true, 
the system will skip error messages. If set to false, will throw exceptions.
2. use try/catch to wrap butter.update in SystemConsumers.
3. added method in TaskConfig.
4. added Test method in TestSystemConsumers
5. updated the configuration page to include the new property.


Diffs (updated)
-----

  docs/learn/documentation/0.7.0/jobs/configuration-table.html 07cb83f 
  samza-core/src/main/scala/org/apache/samza/config/TaskConfig.scala 18a9510 
  samza-core/src/main/scala/org/apache/samza/container/SamzaContainer.scala 
356adbb 
  samza-core/src/main/scala/org/apache/samza/system/SystemConsumers.scala 
b537046 
  
samza-core/src/main/scala/org/apache/samza/system/SystemConsumersMetrics.scala 
d632314 
  samza-core/src/main/scala/org/apache/samza/system/SystemProducers.scala 
8fb36b3 
  
samza-core/src/main/scala/org/apache/samza/system/SystemProducersMetrics.scala 
594dd51 
  samza-core/src/test/scala/org/apache/samza/system/TestSystemConsumers.scala 
e1a4c15 
  samza-core/src/test/scala/org/apache/samza/system/TestSystemProducers.scala 
PRE-CREATION 

Diff: https://reviews.apache.org/r/23235/diff/


Testing
-------


Thanks,

Yan Fang

Reply via email to