-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24216/
-----------------------------------------------------------

Review request for samza.


Bugs: SAMZA-350
    https://issues.apache.org/jira/browse/SAMZA-350


Repository: samza


Description
-------

remove extra info setattribute


clean up tests to use constants


reformat comment


test now checks that debug lines are filtered


fully working test


javadocs


move log4j to test


initial implementation of jmx appender


Diffs
-----

  build.gradle 3ad5fe38113f02307c0e92a3100ee39ef5f030c8 
  gradle/dependency-versions.gradle c8bd830c36d9b815dcc92fcb374c0a0e83b64082 
  
samza-core/src/test/scala/org/apache/samza/metrics/reporter/TestJmxReporter.scala
 357b290603b3aa72c37b9f058608013580cdc4cc 
  samza-log4j/src/main/java/org/apache/samza/logging/log4j/JmxAppender.java 
PRE-CREATION 
  samza-log4j/src/test/java/org/apache/samza/logging/log4j/TestJmxAppender.java 
PRE-CREATION 
  samza-log4j/src/test/resources/log4j.xml PRE-CREATION 
  settings.gradle db5c32b050f793a3b6cc0e4c29f7da86858dd403 

Diff: https://reviews.apache.org/r/24216/diff/


Testing
-------


Thanks,

Chris Riccomini

Reply via email to