----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23715/#review49825 -----------------------------------------------------------
samza-core/src/main/scala/org/apache/samza/container/RunLoop.scala <https://reviews.apache.org/r/23715/#comment87196> Can we just have nested updateTimer calls here? samza-core/src/main/scala/org/apache/samza/container/RunLoop.scala <https://reviews.apache.org/r/23715/#comment87195> This seems generally useful.I think the best way to do this is to have a class in the util package called Timers. This class will inherit a clock from the constructor that it's mixed in with. See MetricsHelper, SamzaContainerMetrics, and SamzaContainer for an example of how to do this. The Timers class can have a single time() method, as you've defined. Then, we can extend Timers in RunLoop. Maybe TimerUtils is better than Timers, as a class name. I'm open to suggestion. - Chris Riccomini On Aug. 6, 2014, 4:17 p.m., Yan Fang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23715/ > ----------------------------------------------------------- > > (Updated Aug. 6, 2014, 4:17 p.m.) > > > Review request for samza. > > > Repository: samza > > > Description > ------- > > Add metrics for choose/process/window/commit/send time > > > Diffs > ----- > > samza-core/src/main/scala/org/apache/samza/container/RunLoop.scala 7fb4763 > > samza-core/src/main/scala/org/apache/samza/container/SamzaContainerMetrics.scala > bcb3fa3 > samza-core/src/test/scala/org/apache/samza/container/TestRunLoop.scala > d4ceffc > > Diff: https://reviews.apache.org/r/23715/diff/ > > > Testing > ------- > > > Thanks, > > Yan Fang > >
