-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24863/
-----------------------------------------------------------
(Updated Aug. 19, 2014, 8:50 p.m.)
Review request for samza.
Bugs: SAMZA-382
https://issues.apache.org/jira/browse/SAMZA-382
Repository: samza
Description (updated)
-------
switching to catch any exception
Revert "do environment variable validation in SamzaContainer. clean up JMX test
in SamzaContainer to use container name exception."
This reverts commit efe56adbf5ac9327f8781da4186f8bb438bd5eb8.
do environment variable validation in SamzaContainer. clean up JMX test in
SamzaContainer to use container name exception.
move main method into a separate method to allow a mock-able JmxServer. write a
test to validate that the jmx server is not properly called on certain
exceptions. fix by moving the try block to include all logic in the main method.
fix random typo in comments
Diffs (updated)
-----
samza-core/src/main/scala/org/apache/samza/container/SamzaContainer.scala
d574ac413c0ec81e12eb44b2d0cc0d9843aad434
samza-core/src/test/scala/org/apache/samza/container/TestSamzaContainer.scala
e3c7fe3e2d329b0767eb439144b1ba419848bb96
Diff: https://reviews.apache.org/r/24863/diff/
Testing
-------
Thanks,
Chris Riccomini
