----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25039/#review51563 -----------------------------------------------------------
Ship it! Minor comment. Looks good otherwise. samza-kafka/src/main/scala/org/apache/samza/checkpoint/kafka/KafkaCheckpointManagerFactory.scala <https://reviews.apache.org/r/25039/#comment89974> Should we make this configurable ? - Chinmay Soman On Aug. 26, 2014, 4:01 p.m., Chris Riccomini wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25039/ > ----------------------------------------------------------- > > (Updated Aug. 26, 2014, 4:01 p.m.) > > > Review request for samza. > > > Bugs: SAMZA-388 > https://issues.apache.org/jira/browse/SAMZA-388 > > > Repository: samza > > > Description > ------- > > misc fixes from rb > > > Merge branch 'master' into SAMZA-393 > > > turn on log compaction for checkpoint topics. force compression off for > checkpoint producer. write a test to verify. > > > Diffs > ----- > > > samza-kafka/src/main/scala/org/apache/samza/checkpoint/kafka/KafkaCheckpointManager.scala > f3e954a6ee588fc40d970dee23e3bbfccbfd2031 > > samza-kafka/src/main/scala/org/apache/samza/checkpoint/kafka/KafkaCheckpointManagerFactory.scala > 977330fd60df2327424f193ae5b6f9849ee72b01 > > samza-kafka/src/test/scala/org/apache/samza/checkpoint/kafka/TestKafkaCheckpointManager.scala > 34fe6ddb30b75a8dcca262188eff5832d8f7abf0 > > Diff: https://reviews.apache.org/r/25039/diff/ > > > Testing > ------- > > > Thanks, > > Chris Riccomini > >
