> On Aug. 26, 2014, 3:26 p.m., Chris Riccomini wrote: > > samza-kv/src/main/scala/org/apache/samza/storage/kv/CachedStore.scala, line > > 131 > > <https://reviews.apache.org/r/25048/diff/1/?file=668646#file668646line131> > > > > For succinctness, can we do: > > > > this.dirty = new mutable.DoubleLinkedList(key, this.dirty) > > > > This looks like it's how things were before SAMZA-80. > > > > > > https://issues.apache.org/jira/secure/attachment/12616195/SAMZA-80.0.patch
Done. - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25048/#review51530 ----------------------------------------------------------- On Aug. 26, 2014, 12:24 a.m., David Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25048/ > ----------------------------------------------------------- > > (Updated Aug. 26, 2014, 12:24 a.m.) > > > Review request for samza. > > > Bugs: SAMZA-162 > https://issues.apache.org/jira/browse/SAMZA-162 > > > Repository: samza > > > Description > ------- > > SAMZA-162: Remove Scala 2.8 kludge in CachedStore. > > > Diffs > ----- > > > samza-kv-leveldb/src/test/scala/org/apache/samza/storage/kv/TestKeyValueStores.scala > d6d437ab7a8b18002dbeb54d85c6c2b5eb43784c > samza-kv/src/main/scala/org/apache/samza/storage/kv/CachedStore.scala > 7a5e510763757634a2f3d3a11eba0fbf47aed9dd > > Diff: https://reviews.apache.org/r/25048/diff/ > > > Testing > ------- > > All tests pass > > > Thanks, > > David Chen > >
