----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27388/#review59241 -----------------------------------------------------------
Ship it! Ship It! - Chinmay Soman On Oct. 30, 2014, 5:58 p.m., Chris Riccomini wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27388/ > ----------------------------------------------------------- > > (Updated Oct. 30, 2014, 5:58 p.m.) > > > Review request for samza. > > > Repository: samza > > > Description > ------- > > export required to set JAVA_OPTS in run-class.sh wrappers > > > export not needed since exec is used > > > only override propertes if they're not set in task.opts for > log4j.configuration samza.log.dir samza.container.name java.io.tmpdir > > > Diffs > ----- > > samza-core/src/main/scala/org/apache/samza/job/local/ThreadJobFactory.scala > 766df7651064552923500fcbba959c343f2849f4 > samza-shell/src/main/bash/checkpoint-tool.sh > 5688b59e32e10f8eeff6ecfd3c3589d08ce8ba8e > samza-shell/src/main/bash/kill-yarn-job.sh > d42e08679510c9ed196764ed24965f067d8ace7d > samza-shell/src/main/bash/run-am.sh > 3a6d40d854208fd61403825c40747b95cb2a869e > samza-shell/src/main/bash/run-class.sh > 2395b59453d7d7b3adc65ba44269a3fa7238c4d3 > samza-shell/src/main/bash/run-container.sh > af00eba71171d0fc6158abdc9fba9dc9c56c17ef > samza-shell/src/main/bash/run-job.sh > d43b556bb0e4f57185c491105e506fd8c9642c1f > samza-shell/src/main/bash/run-migration-tool.sh > 7ac7f279672f73f6c31723845ce0d118dd8fd4bc > > Diff: https://reviews.apache.org/r/27388/diff/ > > > Testing > ------- > > > Thanks, > > Chris Riccomini > >
