-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28035/
-----------------------------------------------------------
(Updated Nov. 24, 2014, 8:20 p.m.)
Review request for samza.
Changes
-------
updated based on Chris' and Chinmay's comments.
added colon
added static for the constants
renamed from getSystemFactoryAsString to getSystemFactor
throw exception when jobName is null
added MDC
Bugs: SAMZA-310
https://issues.apache.org/jira/browse/SAMZA-310
Repository: samza
Description
-------
Added a log4j appender using SystemProducer
Added a log4jConfig class to help get log4j specific config
Unit test code
Diffs (updated)
-----
build.gradle 828bce9
docs/learn/documentation/versioned/jobs/configuration-table.html fbb5ea4
docs/learn/documentation/versioned/jobs/logging.md 58e56c1
samza-core/src/main/scala/org/apache/samza/container/SamzaContainer.scala
2b53440
samza-log4j/src/main/java/org/apache/samza/config/Log4jSystemConfig.java
PRE-CREATION
samza-log4j/src/main/java/org/apache/samza/logging/log4j/StreamAppender.java
PRE-CREATION
samza-log4j/src/test/java/org/apache/samza/config/TestLog4jSystemConfig.java
PRE-CREATION
samza-log4j/src/test/java/org/apache/samza/logging/log4j/MockSystemFactory.java
PRE-CREATION
samza-log4j/src/test/java/org/apache/samza/logging/log4j/MockSystemProducer.java
PRE-CREATION
samza-log4j/src/test/java/org/apache/samza/logging/log4j/TestStreamAppender.java
PRE-CREATION
samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaAppMaster.scala
91aff3c
Diff: https://reviews.apache.org/r/28035/diff/
Testing
-------
Thanks,
Yan Fang
