github-code-scanning[bot] commented on code in PR #101:
URL:
https://github.com/apache/santuario-xml-security-java/pull/101#discussion_r1221887613
##########
src/main/java/org/apache/xml/security/stax/impl/util/DigestOutputStream.java:
##########
@@ -67,9 +66,9 @@
public byte[] getDigestValue() {
if (isDebugEnabled) {
- LOG.debug("Pre Digest: ");
- LOG.debug(stringBuilder.toString());
- LOG.debug("End pre Digest ");
+ LOG.log(Level.DEBUG, "Pre Digest: ");
+ LOG.log(Level.DEBUG, stringBuilder.toString());
Review Comment:
## Log Injection
This log entry depends on a [user-provided value](1).
[Show more
details](https://github.com/apache/santuario-xml-security-java/security/code-scanning/1125)
##########
src/main/java/org/apache/xml/security/stax/impl/processor/input/AbstractDecryptInputProcessor.java:
##########
@@ -344,7 +343,8 @@
XMLStreamReader xmlStreamReader =
inputProcessorChain.getSecurityContext().<XMLInputFactory>get(
XMLSecurityConstants.XMLINPUTFACTORY).createXMLStreamReader(
- new MultiInputStream(prologInputStream,
decryptInputStream, epilogInputStream), StandardCharsets.UTF_8.name());
+ new MultiInputStream(prologInputStream,
decryptInputStream, epilogInputStream),
Review Comment:
## Potential input resource leak
This MultiInputStream is not always closed on method exit.
[Show more
details](https://github.com/apache/santuario-xml-security-java/security/code-scanning/1121)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
