coheigea commented on code in PR #177:
URL: 
https://github.com/apache/santuario-xml-security-java/pull/177#discussion_r1231807718


##########
src/test/java/org/apache/xml/security/test/dom/signature/ECDSASignatureTest.java:
##########
@@ -69,14 +70,14 @@ public ECDSASignatureTest() throws Exception {
 
         org.apache.xml.security.Init.init();
         try {
-            int javaVersion = 
Integer.parseInt(System.getProperty("java.specification.version"));
+            int javaVersion = Integer.getInteger("java.specification.version");

Review Comment:
   This change is causing a NPE in the tests (Java 8):
   ```
   [ERROR] 
org.apache.xml.security.test.dom.signature.ECDSASignatureTest.testKeyValue  
Time elapsed: 0.001 s  <<< ERROR!
   java.lang.NullPointerException
       at 
org.apache.xml.security.test.dom.signature.ECDSASignatureTest.<init>(ECDSASignatureTest.java:73)
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to