dmatej commented on PR #186: URL: https://github.com/apache/santuario-xml-security-java/pull/186#issuecomment-1635766499
> I was last week but back now :-) IMO these changes are too intrusive and are not necessary. Can we restrict adding final to member variables? Then it is easier for me just to revert all these changes in the #101 . The project doesn't have any rules, so it is just your opinions and I have to respect them. I already spent too much time with this project which was basically just reducing differences between branches. This PR was to set the same rule everywhere, yet without checkstyle which I would recommend too, BUT ... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
