jrihtarsic commented on code in PR #219: URL: https://github.com/apache/santuario-xml-security-java/pull/219#discussion_r1350098480
########## src/test/java/org/apache/xml/security/utils/XMLUtilsTest.java: ########## @@ -0,0 +1,56 @@ +package org.apache.xml.security.utils; Review Comment: Sure, I will do that. I have a question: if is it okay to add "third-party library" com.sun.xml.messaging.saaj:saaj-impl to test this (I added that library because we had an issue with it using JDK 11), or is this a bit overkill? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
