seanjmullan commented on PR #234: URL: https://github.com/apache/santuario-xml-security-java/pull/234#issuecomment-1863451255
I am pretty much done with my review. I think the javadoc could be improved in various methods/classes but I don't want to hold this up anymore and this can probably be improved in the next revision or over time. I did not review the tests, so hopefully those are ok or someone else has reviewed them. Sorry it took so long. I'll do a final sanity check tomorrow on your latest commits and then if all looks good, add my approval. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
