yklymenko commented on PR #293:
URL: 
https://github.com/apache/santuario-xml-security-java/pull/293#issuecomment-2008161675

   > > > Looks fine. It would be nice if there was also a test using the 
`javax.xml.crypto.dsig` API.
   > > 
   > > 
   > > @seanjmullan you mean, something like 
org.apache.xml.security.test.dom.signature.EDDSASignatureTest ? I could try in 
the next days create such test
   > 
   > Yes, something like that would be great.
   
   @seanjmullan  I've added the test.  I have some problem to run 
org.apache.xml.security.utils.KeyUtilsTest unter jdk17 with profile 
bouncecastle. The "DH" Case for generateEphemeralDHKeyPair  seems to be broken. 
org.apache.xml.security.utils.KeyUtils.KeyType#DH declaration use 
1.2.840.113549.1.3.1 oid, but 1.2.840.10046.2.1 seems to be the correct one 
(http://oid-info.com/get/1.2.840.10046.2.1). Or may be I'm wrong?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to