On Fri, 2009-07-31 at 17:05 +0200, Niklas Nebel wrote: > On 07/31/09 16:28, Kohei Yoshida wrote: > >> - Extensions to the DataPilotSource API must be done in a compatible way > >> (see the handling of the "Filter" property). > > > > I've reviewed my change against the baseline, and my only addition to > > the UNO API is two new constant values to MemberResultFlags. It's my > > understanding that adding new constant values to the existing constant > > set is considered binary compatible. > > > > Having said that, it's entirely possible that I'm misunderstanding the > > intent of your comment here, so could you please clarify on this point? > > An extension can supply its own implementation of the DataPilotSource > service, which can then be used with the "External source/interface" > option (see > http://wiki.services.openoffice.org/wiki/Documentation/DevGuide/Spreadsheets/DataPilot_Sources). > > To maintain compatibility with such extensions, Calc must not rely on > the presence of new, added properties. This is different from services > which are only implemented in Calc.
Gotcha. > > > Also, I'd like to see how the "Filter" property was handled in a > > compatible way. Could you point me to the place to look for? I did my > > own search, but I couldn't find what may look like the code you are > > referring to. > > For the "Filter" property, ScDPSaveDimension::WriteToSource just has to > be prepared for an exception from setPropertyValue, because it's not an > error if that property isn't supported. Now I understand. It appears that I was looking at the wrong place (offapi). Anyway, I've made changes so that optional properties are treated as such. > > > I've switched to using SvxCheckListBox for the member list control. So, > > that should take care of that part of the accessibility, I assume. > > > > Also, I'd like to know more about the accessibility function > > requirements. Could you give me some pointers, please? I'm not that > > familiar with accessibility requirements, as that subject always sounded > > too abstract to me... Any details would be great. > > It has to work. :-) My goodness... I haven't looked into this yet, but this could be a big hurdle to overcome depending on what level of change is required to get it work fully. Any chance we can integrate this feature without accessibility, by leaving the accessibility a known issue for future work? :-) > See http://wiki.services.openoffice.org/wiki/Accessibility for some more > information and which tools can be used. Thanks. This is useful, though I have to say I'm stepping into an area where I have no prior expertize. Kohei -- Kohei Yoshida - OpenOffice.org Engineer - Novell, Inc. <[email protected]> --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
