[ https://issues.apache.org/jira/browse/SDAP-161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16714993#comment-16714993 ]
ASF GitHub Bot commented on SDAP-161: ------------------------------------- quintinali commented on a change in pull request #35: SDAP-161 MUDROD embedded unit test URL: https://github.com/apache/incubator-sdap-mudrod/pull/35#discussion_r240271668 ########## File path: core/src/test/java/org/apache/sdap/mudrod/weblog/structure/log/GeoIpTest.java ########## @@ -0,0 +1,18 @@ +package org.apache.sdap.mudrod.weblog.structure.log; + +import static org.junit.Assert.*; + +import org.junit.Assert; +import org.junit.Test; + +public class GeoIpTest { + + @Test + public void testToLocation() { + GeoIp ip = new GeoIp(); + String iptest = "185.10.104.194"; + Coordinates result = ip.toLocation(iptest); + Assert.assertEquals("failed in geoip function!", "22.283001,114.150002", result.latlon); + } + +} Review comment: I remembered that @fgreg has added a function of decompressing zip log file for MUDROD. And the test code can parse the two gz. file. If you need, I can depress them for you. Is it necessary? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > MUDROD embedded unit test > ------------------------- > > Key: SDAP-161 > URL: https://issues.apache.org/jira/browse/SDAP-161 > Project: Apache Science Data Analytics Platform > Issue Type: Improvement > Components: mudrod > Affects Versions: 1.0 > Reporter: Yun Li > Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)