fgreg commented on a change in pull request #101:
URL:
https://github.com/apache/incubator-sdap-nexus/pull/101#discussion_r444360805
##########
File path: analysis/webservice/webapp.py
##########
@@ -25,10 +25,16 @@
import pkg_resources
import tornado.web
from tornado.options import define, options, parse_command_line
-
from webservice import NexusHandler
from webservice.webmodel import NexusRequestObject, NexusProcessingException
+logging.basicConfig(
Review comment:
Care should be taken when configuring `logging` in globally like this.
Now, whenever this module is imported, logging will be configured (unless it
was already configured by some other module which also does this). Generally,
it is better to configure logging in `__main__`, is there a reason you wanted
to move it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
