skorper edited a comment on pull request #131:
URL: 
https://github.com/apache/incubator-sdap-nexus/pull/131#issuecomment-888728581


   @ngachung I've added some unit tests (matchup only for now) that exercise 
the satellite to satellite functionality. Changes are as follows:
   
   - renamed matchup test module to `test_matchup.py`
   - Removed tests that contained syntax error (no idea what they were supposed 
to be calling but it didn't exist)
   - Moved integration tests to a new location and added integration pytest 
marker (I have not tested these existing integration tests)
   - Added 2 new tests to test_matchup.py that exercise the bulk of the matchup 
algorithm
      - For these tests, I've hardcoded the primary and secondary points and 
hand calculated the expected result.
   - Added a README to the test directory with instructions on how to run the 
unit tests.
   
   Note: The exists tests are not in a functional state, the only tests I've 
worked on are the matchup tests. 
   
   ```sh
   ➜ pytest analysis/tests/algorithms_spark/test_matchup.py                     
                                     
   
========================================================================================================================================================================================
 test session starts 
=========================================================================================================================================================================================
   platform darwin -- Python 3.8.5, pytest-6.2.2, py-1.10.0, pluggy-0.13.1
   rootdir: /Users/skperez/Documents/ACCESS/incubator-sdap-nexus/analysis
   collected 3 items                                                            
                                                                                
                                                                                
                                                                                
                                                                        
   
   analysis/tests/algorithms_spark/test_matchup.py ...      
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to