skorper commented on a change in pull request #142:
URL: 
https://github.com/apache/incubator-sdap-nexus/pull/142#discussion_r739458964



##########
File path: analysis/webservice/apidocs/openapi.yml
##########
@@ -671,12 +673,19 @@ components:
           type: string
         source:
           type: string
-        analysed_sst:
-          type: number # TODO Fix this
         matches:
           type: array
           items:
-            $ref: '#/components/schemas/DomsPoint'
+            $ref: '#/components/schemas/DomsPointSecondary'

Review comment:
       Thanks @joshgarde! I believe I've addressed the circular reference by 
moving the `matches` property from `DomsPointBase` to `DomsPointPrimary`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sdap.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to