wphyojpl commented on code in PR #2:
URL:
https://github.com/apache/incubator-sdap-in-situ-data-services/pull/2#discussion_r869723629
##########
k8s_spark/parquet.spark.helm/templates/secret.yaml:
##########
@@ -1,9 +1,11 @@
+{{ with .Values.aws_creds }}
apiVersion: v1
kind: Secret
type: Opaque
metadata:
- name: {{ .Release.Name }}-auth
+ name: {{ $.Release.Name }}-auth
data:
- awskey: {{ if .Values.aws_creds.awskey }}{{ .Values.aws_creds.awskey |
b64enc }}{{- else }}''{{- end }}
- awssecret: {{ if .Values.aws_creds.awssecret }}{{
.Values.aws_creds.awssecret | b64enc }}{{- else }}''{{- end }}
- awstoken: {{ if .Values.aws_creds.awstoken }}{{ .Values.aws_creds.awstoken |
b64enc }}{{- else }}''{{- end }}
+ awskey: {{ .awskey | b64enc }}
+ awssecret: {{ .awssecret | b64enc }}
+ awstoken: {{ .awstoken | b64enc }}
Review Comment:
Got this error while trying to use these.
```
Error: unable to build kubernetes objects from release manifest: error
validating "": error validating data: unknown object type "nil" in
Secret.data.awstoken
```
I have to update to this:
```
awskey: {{ if .awskey }}{{ .awskey | b64enc }}{{- else }}''{{- end }}
awssecret: {{ if .awssecret }}{{ .awssecret | b64enc }}{{- else }}''{{-
end }}
awstoken: {{ if .awstoken }}{{ .awstoken | b64enc }}{{- else }}''{{- end }}
```
Is that a correct change? @briansaildrone
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sdap.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
