RKuttruff commented on code in PR #207:
URL:
https://github.com/apache/incubator-sdap-nexus/pull/207#discussion_r1004727473
##########
analysis/webservice/algorithms/doms/insitu.py:
##########
@@ -60,12 +66,22 @@ def query_insitu(dataset, variable, start_time, end_time,
bbox, platform, depth_
# Page through all insitu results
next_page_url = insitu_endpoints.getEndpoint(provider, dataset)
while next_page_url is not None and next_page_url != 'NA':
- if session is not None:
- response = session.get(next_page_url, params=params)
+ thetime = datetime.now()
+ if params == {}:
+ logging.info(f"Starting insitu request: {next_page_url}")
else:
- response = requests.get(next_page_url, params=params)
+ logging.info(f"Starting insitu request:
{next_page_url}?{urlencode(params)}")
+
+
+ try:
+ if session is not None:
+ response = session.get(next_page_url, params=params,
timeout=(15.05, 331))
Review Comment:
First one is connect timeout, second is read timeout.
I suppose it would be beneficial to fail quickly if we can't even connect
rather than wait a whole 5 minutes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sdap.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
