RKuttruff commented on code in PR #261:
URL:
https://github.com/apache/incubator-sdap-nexus/pull/261#discussion_r1279704233
##########
analysis/webservice/algorithms/doms/BaseDomsHandler.py:
##########
@@ -94,6 +94,10 @@ def __init__(self, results=None, args=None, bounds=None,
count=None, details=Non
self.__details = details
self.__executionId = str(executionId)
+ # Add page num and size to details block
+ self.__details['pageNum'] = page_num
+ self.__details['pageSize'] = page_size
Review Comment:
In the issue that #263 fixed it was `None` because of the type of results
that class returned. It may be worthwhile to just precede that with a quick
check like
```python
if self.__details is None:
self.__details = {}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sdap.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
