RKuttruff commented on code in PR #267:
URL:
https://github.com/apache/incubator-sdap-nexus/pull/267#discussion_r1302067956
##########
analysis/webservice/algorithms/doms/ResultsStorage.py:
##########
@@ -285,7 +285,8 @@ def __enrichPrimaryDataWithMatches(self, id, dataMap,
trim_data=False):
dataMap[row.primary_value_id]["matches"] = []
dataMap[row.primary_value_id]["matches"].append(entry)
else:
- print(row)
+ # print(row)
+ pass
Review Comment:
@ngachung
> It’s in the pagination PR
[https://github.com/apache/incubator-sdap-nexus/blob/b1aa0910909ad8299a62bad6f235cc[…]0c65e6383/analysis/webservice/algorithms/doms/ResultsStorage.py](https://github.com/apache/incubator-sdap-nexus/blob/b1aa0910909ad8299a62bad6f235cc80c65e6383/analysis/webservice/algorithms/doms/ResultsStorage.py#L305-L313)
Gets some results for the execution ID, but then in lines 310-312 the data
map is only for the subset of rows that match the page
[https://github.com/apache/incubator-sdap-nexus/blob/b1aa0910909ad8299a62bad6f235cc[…]0c65e6383/analysis/webservice/algorithms/doms/ResultsStorage.py](https://github.com/apache/incubator-sdap-nexus/blob/b1aa0910909ad8299a62bad6f235cc80c65e6383/analysis/webservice/algorithms/doms/ResultsStorage.py#L292-L298)
Here a very similar query is run, but when the returned rows are iterated
over, it iterates over the whole Cassandra result, not just the rows that match
the page
##########
analysis/webservice/algorithms/doms/ResultsStorage.py:
##########
@@ -285,7 +285,8 @@ def __enrichPrimaryDataWithMatches(self, id, dataMap,
trim_data=False):
dataMap[row.primary_value_id]["matches"] = []
dataMap[row.primary_value_id]["matches"].append(entry)
else:
- print(row)
+ # print(row)
+ pass
Review Comment:
@ngachung
> It’s in the pagination PR
[https://github.com/apache/incubator-sdap-nexus/blob/b1aa0910909ad8299a62bad6f235cc[…]0c65e6383/analysis/webservice/algorithms/doms/ResultsStorage.py](https://github.com/apache/incubator-sdap-nexus/blob/b1aa0910909ad8299a62bad6f235cc80c65e6383/analysis/webservice/algorithms/doms/ResultsStorage.py#L305-L313)
Gets some results for the execution ID, but then in lines 310-312 the data
map is only for the subset of rows that match the page
[https://github.com/apache/incubator-sdap-nexus/blob/b1aa0910909ad8299a62bad6f235cc[…]0c65e6383/analysis/webservice/algorithms/doms/ResultsStorage.py](https://github.com/apache/incubator-sdap-nexus/blob/b1aa0910909ad8299a62bad6f235cc80c65e6383/analysis/webservice/algorithms/doms/ResultsStorage.py#L292-L298)
Here a very similar query is run, but when the returned rows are iterated
over, it iterates over the whole Cassandra result, not just the rows that match
the page
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sdap.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
