Sounds to me as if the ‘hiccup’ is just a bug and can be addressed by documenting it in the release notes (i.e. without needing a new RC). The bigger issue addressed by the release is the need to remove all category X dependencies. That said, I’m not the RM so it’s not my call.
+1 (binding) Downloaded, checked hashes, NOTICE, DISCLAIMER, LICENSE, README, requirements.txt (dependencies) of the two artifacts, license headers. Julian > On Mar 6, 2024, at 12:55 PM, Riley Kuttruff <r...@apache.org> wrote: > > Thanks, Nga. > > There's currently a small hiccup causing errors for the build for the > collection manager > when run with the --no-cache option. This shouldn't be a blocker for anyone > who has built the image before (if they use the cached layers; it's not a > step > involved with our code) or they could use a simple workaround. > > I have a PR with a fix open. I'll defer to Stepheny if we want to do a new RC > to address this or if we want to proceed as-is. > > -Riley > > On 2024/03/06 20:41:58 Nga Chung wrote: >> Thank you, Riley and Stepheny, for getting this rc out with the >> changes to use Poetry! >> >> I verified the release as follows: >> - Verified artifacts checksums and signatures >> - Successfully built local images per build.rst >> - Successfully ran through all steps in quickstart.rst and ran Jupyter >> notebook >> >> +1 from me (binding) >> >> Thanks, >> Nga >> >> On Tue, Mar 5, 2024 at 9:27 AM Stepheny Perez <skpe...@apache.org> wrote: >>> >>> Hello everyone, >>> >>> This is the vote to approve Apache SDAP (incubating) release candidate rc4 >>> for version 1.2.0. >>> >>> Changes made between previous candidate (rc3) and this one (rc4) are as >>> follows: >>> - Updated SDAP to use Poetry package manager to more explicitly manage >>> dependencies and transitive dependencies. This was needed to ensure no GPL >>> license dependencies are used by the software. >>> - Patch for domspurge helper script >>> >>> Instructions for building docker images from source can be found here: >>> https://github.com/apache/incubator-sdap-nexus/blob/1.2.0-rc4/docs/build.rst >>> Instructions for deploying locally to test can be found here: >>> https://github.com/apache/incubator-sdap-nexus/blob/1.2.0-rc4/docs/quickstart.rst >>> The release files, including signatures, digests, etc. can be found at: >>> https://dist.apache.org/repos/dist/dev/incubator/sdap/apache-sdap-1.2.0-rc4/ >>> >>> For convenience, the tags we built the release artifacts to be voted on >>> from are 1.2.0-rc4: >>> >>> - ingester: >>> - URL: https://github.com/apache/incubator-sdap-ingester/tree/1.2.0-rc4 >>> - Commit: 5c116badfaf913734d017d41acc765ed3fd978a1 >>> >>> - nexus: >>> - URL: https://github.com/apache/incubator-sdap-nexus/tree/1.2.0-rc4 >>> - Commit: 3fce31f08b9057db446036724e8bc62dd6d1560a >>> >>> For verification, the hashes (SHA-512) of the .tar.gz artifacts we are >>> voting on are as follows: >>> >>> apache-sdap-ingester-1.2.0-incubating-src.tar.gz: >>> 7301c54e765882c45f6efe4a06463b837ace62b6eea2ae5437113357466e52f1d905c3c9d46295f1b1058b9ecf5025942f8a89b2c53a1b0d6b69cd52a8890257 >>> >>> apache-sdap-nexus-1.2.0-incubating-src.tar.gz: >>> 1a2907f9c36dbf0b4b25d54c095303ab0602fa9e0a9423deceae402ffd9a360e21ba832c3ea497d8eccbc6c91fedd2926b3b33181a14c22d50d0ec996282bc75 >>> >>> Release artifacts are signed with the following key: >>> https://keyserver.ubuntu.com/pks/lookup?op=get&search=0x2E8418801953621FAA322169D6F360887071C194 >>> >>> Please vote on releasing this package as Apache SDAP (incubating) 1.2.0-rc4. >>> >>> The vote is open for 72 hours and passes if at least 3 +1 PMC votes are >>> cast. >>> >>> PLEASE NOTE: Do not reply with a vote from your work email as it can mangle >>> the links. To vote, go to >>> https://lists.apache.org/list.html?dev@sdap.apache.org, log in and send >>> your reply from there. >>> >>> [ ] +1 Release this package as Apache SDAP (incubating) {version} >>> [ ] +0 No opinion >>> [ ] -1 Do not release this package because ... >>> >>> Thank you, >>> Stepheny >>
