ngachung commented on code in PR #327:
URL: https://github.com/apache/sdap-nexus/pull/327#discussion_r1801455699


##########
docs/quickstart.rst:
##########
@@ -143,7 +143,7 @@ To start Solr using a volume mount and expose the admin 
webapp on port 8983:
 
   export SOLR_DATA=~/nexus-quickstart/solr
   mkdir -p ${SOLR_DATA}
-  docker run --name solr --network sdap-net -v ${SOLR_DATA}/:/bitnami -p 
8983:8983 -e SDAP_ZK_SERVICE_HOST="host.docker.internal" -d 
${REPO}/sdap-solr-cloud:${SOLR_VERSION}
+  docker run --name solr --network sdap-net -v ${SOLR_DATA}/:/bitnami -p 
8983:8983 -e ZK_HOST="host.docker.internal:2181/solr" -d 
${REPO}/sdap-solr-cloud:${SOLR_VERSION}

Review Comment:
   I don't see how setting SDAP_ZK_SERVICE_HOST has any effect.
   The Solr image is based of this Dockerfile 
https://github.com/apache/sdap-nexus/blob/develop/docker/solr/Dockerfile which 
is based off bitnami/solr:8.11.1-debian-10-r0, so how would it make use of an 
SDAP specific environment variable?
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sdap.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to