funky-eyes commented on code in PR #6206:
URL: https://github.com/apache/incubator-seata/pull/6206#discussion_r1436031567
##########
discovery/seata-discovery-zk/src/main/java/io/seata/discovery/registry/zk/ZookeeperRegisterServiceImpl.java:
##########
@@ -310,6 +310,41 @@ private void refreshClusterAddressMap(String clusterName,
List<String> instances
CLUSTER_ADDRESS_MAP.put(clusterName, newAddressList);
}
+ /**
+ *
+ * clear cluster's zk listener
+ *
+ * @param clusterName clusterName
+ */
+ private void clearClusterListener(String clusterName) {
+ List<IZkChildListener> listeners =
LISTENER_SERVICE_MAP.get(clusterName);
+ for (IZkChildListener listener : listeners) {
+ try {
+ unsubscribe(clusterName, listener);
+ } catch (Exception e) {
+ LOGGER.warn("unsubscribe cluster {} failed", clusterName);
+ }
+ }
+ }
+
+ /***
+ *
+ * check whether it is current cluster
+ *
+ * @param clusterName cluserName
+ */
+ private boolean isCurrentCluster(String clusterName) {
+ String txServiceGroupName = ConfigurationFactory.getInstance()
Review Comment:
如果使用的是seata-all，这个配置很有可能读不到，比如以下写法：
If you are using seata-all, this configuration is likely to be unreadable,
such as the following:
`new GlobalTransactionScanner("test", "group_a", failureHandler);`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
