funky-eyes commented on issue #6189: URL: https://github.com/apache/incubator-seata/issues/6189#issuecomment-1877998537
> 我觉得size这个变量名称没必要改,因为 > > 1. 具有通用性,后续如果变了单位,难道要再次兼容吗? > 2. 项目中很多地方都用这个size,要改的话需要全部改,风险比较大 > 建议在注释中写清楚这个单位是什么,然后改一下log打印的内容就可以了 你说的也是一种方式，先把错误的提示改了，再从日志中增加单位提示 What you said is also a way. Change the wrong prompt first, and then add the unit prompt from the log. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
