Bughue commented on code in PR #6208: URL: https://github.com/apache/incubator-seata/pull/6208#discussion_r1442439517
########## serializer/seata-serializer-seata/src/main/java/io/seata/serializer/seata/SeataSerializer.java: ########## @@ -16,52 +16,133 @@ */ package io.seata.serializer.seata; -import java.nio.ByteBuffer; - import io.netty.buffer.ByteBuf; import io.netty.buffer.Unpooled; import io.seata.common.loader.LoadLevel; +import io.seata.common.loader.Scope; import io.seata.common.util.BufferUtils; import io.seata.core.protocol.AbstractMessage; +import io.seata.core.protocol.ProtocolConstants; import io.seata.core.serializer.Serializer; +import java.nio.ByteBuffer; + /** * The Seata codec. - * */ -@LoadLevel(name = "SEATA") +@LoadLevel(name = "SEATA", scope = Scope.PROTOTYPE) Review Comment: 因为它的构造方法是带有参数的所以不能是单例，所以上次提过new出来之后会有map管理 Because its constructor method is with parameters so can not be singleton, so as mentioned last time, it will be managed by the map after new obj. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
