smiletrl commented on code in PR #47:
URL:
https://github.com/apache/incubator-seata-go-samples/pull/47#discussion_r1469691569
##########
conf/seatago.yml:
##########
@@ -59,7 +59,7 @@ seata:
# Judge whether the before image and after image are the same，If it is
the same, undo will not be recorded
data-validation: true
# Serialization method
- log-serialization: jackson
Review Comment:
`json` is one json parser,
https://github.com/apache/incubator-seata-go/blob/master/pkg/datasource/sql/undo/parser/parser_json.go.
The current implementation does support adding more `UndoLogParser`. Other
than discarding this configuration, I feel we may rename it to `log-parser` to
keep this flexibility.
To achieve this, we may also need to add something like below at
`pkg/datasource/sql/undo/parser` at `seata-go`
```
parser.RegisterParser()
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
