GitHub user YoWuwuuuw added a comment to the discussion: Whether or not bug
>From the code, no matter how the spi mechanism is implemented, the
>RegistryService instance returned by provide () is always singletons .
>Therefore, the above situation is that the List add() the same instance
>repeatedly, resulting in size 2 (shouldn't be the case), as follows:
String registryTypes = RegistryType.File.name() +
Constants.REGISTRY_TYPE_SPLIT_CHAR + RegistryType.File.name();
System.setProperty(REGISTRY_TYPE_KEY, registryTypes);
List<RegistryService> instances = MultiRegistryFactory.getInstances();
Assertions.assertEquals(2, instances.size());
Assertions.assertSame(instances.get(1), instances.get(0));
So I think we can add a check before add() to prevent this from happening, in
#7345
GitHub link:
https://github.com/apache/incubator-seata/discussions/7342#discussioncomment-13218500
----
This is an automatically sent email for [email protected].
To unsubscribe, please send an email to: [email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
