Hi Jiajie Zhong, Yes, I agree with Calvin's idea too. For now, the v2.0 version is quite enough for us. Using command to trigger the process sounds good to me. I implemented it before, so it is feasible. I will create another PR to complete the process.
By the way, I have rewrote the Python script, and now the script completely uses Python's native APIs, does not rely on any third-party libraries, and can run in the native Python environment. Beside, the latest version script already supports the handling of unknown licneses, and all existing unknown protocols have found the corresponding licenses and are correctly marked. FYI, https://github.com/apache/incubator-seatunnel/pull/1210/files Regards, Benedict Jin On 2022/02/10 03:40:56 Jiajie Zhong wrote: > Hey Benedict, > > I agree with Calvin's idea. We should better run check in CI and hint user > how to add license. > But I think if we want to achieve this function. We should a bot and use > commands to trigger > whether to automatically modify files or not. > > I give a simple example here. when bot hint license or header is missing, and > we think it just > add some header to it. we should trigger by simple command in github like > `/auto-license` and > bot would auto add license header to missing file. > > **BUT I think maybe this is too COMPLEX for now** > But if we think we could implement it in a short time, it would be great. > > Otherwise, Benedict idea is OK to me, it use wish to use our dev script to > auto full license or > header, he/she should install python develop envirement locally. Or use could > fix license issue > manually > > Cheers, > — Jiajie Zhong
