Well done, thanks Jia, I will take a look
Best wishes! Calvin Kirs On 09/28/2022 20:51,Jia Fan<[email protected]> wrote: Hi contributers of SeaTunnel. After engine already finished main feature of MVP version. So we want to merge st-engine branch to dev. Lots of code have conflict. So Try my best when I merge code, but I probably have some mistake be made. So can you help me to check the code again? It’s will be very helpful. The PR link: https://github.com/apache/incubator-seatunnel/pull/2928 <https://github.com/apache/incubator-seatunnel/pull/2928> I follow these guidelines when merging code: seatunnel-connectors-v2 based on dev branch seatunnel-engine based on st-engine branch seatunnel-server and seatunel-ui based on dev branch seatunnel-core based on dev branch Thanks! ________________________ Jia Fan
