+1 Need to add description to contribution guide and review check
CalvinKirs <[email protected]> 于2022年10月10日周一 19:08写道： > We should use custom exceptions that have business implications. The > reliance on uniform exceptions is usually to avoid uncaught exceptions, and > we can go ahead and create some public exceptions, such as the public > exception for connector. > > > Best wishes！ > Calvin Kirs > > > On 10/10/2022 18:49，JUN GAO<[email protected]> wrote： > It's a good idea. > > Lucifer Tyrant <[email protected]> 于2022年10月10日周一 14:22写道： > > Hi all, > > So far, the exceptions thrown in the code have not been managed uniformly, > the connector and other modules still use RuntimeException, unified > exception management can make the code more clear and easy to read, and > quickly prompt the user where the exception occurred. > > My idea is a consistent global exception with error codes and error hints > when throwing exceptions. > > My idea is that the global exceptions are consistent, with error codes and > error hints when throwing exceptions, the advantage of doing so is that it > can unify the error message hints, and the unified format helps provide a > better experience for users, when users encounter problems in the process > of use, users can directly locate the problem through the error code and > hint information quickly or submit the error code to the community, this > idea is also borrowed from DataX. For more detailed design, please refer to > the issue: > > https://github.com/apache/incubator-seatunnel/issues/3043 > > If you have better suggestions and solutions, welcome to discuss together☺, > let's make SeaTunnel better and more powerful together.💪 > > Best Regards, > Chao Tian > > > > -- > > Best Regards > > ------------ > > EricJoy2048 > [email protected] >
