Thanks hailin for open this discussion. Agree with your point. ________________________
Jia Fan > 2023年12月26日 22:05，hailin0 <[email protected]> 写道： > > Hi developers, > > In the recent development process, I discovered an issue with PR Review & > Merged. The review did not strictly check whether E2E & unit test are > included, thus causing the code to run unstable. > e.g: > 1. A bug that has already been fixed reappears > 2. Released feature is broken by new commit > 3. Incomplete changes lead to multiple mentions of patch > > Therefore, I would like to suggest that PR reviews must verify that: > 1. Include unit testing & end-to-end testing > 2. Include document changes > 3. Compatibility design and inspection > 4. CI verification passed > > What do you think about this? If you have any advice, please let me know. > > hailin0
