Hi all,
I'd suggest that we look for alternatives around the changes to
userData. When I've talked to Martin Davis (lead JTS developer), he's
been a little unsure and cautious around how userData is used.
As one suggestion, is it possible to separate out comparison and
serialization around userData?
Cheers,
Jim
On 10/15/2020 1:32 AM, Felix Cheung wrote:
They are not too bad - IMO it will be good to pursue getting these changes
accepted in jts
On Wed, Oct 14, 2020 at 10:01 PM Jia Yu <[email protected]> wrote:
Not yet. I am pretty sure that they will not accept all changes if you look
at there:
https://github.com/locationtech/jts/compare/master...jiayuasu:master?expand=1
Especially, the "userdata" part and "findLeafBounds" function.
I am gonna create a PR to JTS, and only keep acceptable changes. This way,
we can at least merge some functions to JTS. But I believe we have to use
this fork in the future.
On Wed, Oct 14, 2020 at 7:59 AM Netanel Malka <[email protected]> wrote:
Hi Jia,
I saw that you merge the PR about make Sedona depend on JTS.
Did you also try to open a PR in the JTS project?
I wondered if they agreed to accept your changes.
BR,
Netanel Malka.
